From: Matthew Daley Date: Thu, 28 Nov 2013 10:17:11 +0000 (+1300) Subject: memshr: fix off-by-one in filename size check X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~5840 X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https:/%22bookmarks://%22Dat/%22http:/www.example.com/cgi/%22https:/%22bookmarks:/%22Dat?a=commitdiff_plain;h=29f3dc1e0715bc9237761ce4a39aed3610a86a85;p=xen.git memshr: fix off-by-one in filename size check Signed-off-by: Matthew Daley Acked-by: Ian Campbell --- diff --git a/tools/memshr/shm.c b/tools/memshr/shm.c index c925cf26ac..30975dcbf6 100644 --- a/tools/memshr/shm.c +++ b/tools/memshr/shm.c @@ -217,9 +217,9 @@ uint16_t shm_vbd_image_get(const char* file, vbd_image_info_t *vbd_imgs) DPRINTF("No space in vbds table.\n"); return 0; } - if(strlen(file) > MAX_NAME_LEN) + if(strlen(file) > MAX_NAME_LEN - 1) { - DPRINTF("Filename: %s too long (>%d).\n", file, MAX_NAME_LEN); + DPRINTF("Filename: %s too long (>%d).\n", file, MAX_NAME_LEN - 1); return 0; } /* Init the entry */